Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Explore]chart/data split view resizing height does not work properly #12102

Closed
junlincc opened this issue Dec 17, 2020 · 3 comments
Closed

[Explore]chart/data split view resizing height does not work properly #12102

junlincc opened this issue Dec 17, 2020 · 3 comments
Assignees
@junlincc
Labels
!deprecated-label:bug Deprecated label - Use #bug instead

Comments

@junlincc
Copy link
Member

junlincc commented Dec 17, 2020 •
edited

Expected behavior:
when user resizes screen vertically, both Chart and Data section should adjust their height accordingly, making sure the data section is alway accessible to user despite the screen sizes.

resizing from the bottom ❌
Screen Shot 2020-12-17 at 11 16 57 AM
Screen Shot 2020-12-17 at 11 17 20 AM
from the side ✅
Screen Shot 2020-12-17 at 11 17 40 AM
From the corner ✅ side first then bottom
From the corner ❌ bottom first then side
Screen Shot 2020-12-17 at 11 17 57 AM
@junlincc junlincc added the !deprecated-label:bug Deprecated label - Use #bug instead label Dec 17, 2020
@junlincc junlincc self-assigned this Dec 17, 2020
@junlincc junlincc added .explore rush! Requires immediate attention and removed rush! Requires immediate attention labels Dec 17, 2020
@junlincc
Copy link
Member Author

@maloun96 hey Victor, mind taking this on? please reach out to the feature owner @kgabryje if you have any questions. thanks!🙏

@maloun96 maloun96 mentioned this issue Jan 4, 2021
Merged
7 tasks
@zuzana-vej
Copy link
Contributor

Screen Shot 2021-01-05 at 4 04 30 PM

Just noticed this on another chart also during resizing (adding screenshot just fyi)

@junlincc
Copy link
Member Author

junlincc commented Jan 6, 2021 •
edited by ktmud

issue is fixed by #12250 but still follow up work need to be done #12296

@junlincc junlincc closed this as completed Jan 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@junlincc junlincc

Labels
!deprecated-label:bug Deprecated label - Use #bug instead
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@zuzana-vej @junlincc